[improve] Replacing characters with http constants #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuluo-yx <[email protected]>
|
hi, It is recommended that constants that are only used in the collector module be placed in the collector module instead of the common module. |
Meaning in CollectorConstants? 🤔 |
move the collector relate constant files into collector module |
|
Okay.i will do it
tomsun28 ***@***.***>于2024年8月11日 周日15:59写道：
… hi, It is recommended that constants that are only used in the collector
module be placed in the collector module instead of the common module.
Meaning in CollectorConstants? 🤔
move the collector relate constant files into collector module
—
Reply to this email directly, view it on GitHub
<#2500 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASS2GCPOMJG2NQADLNE27B3ZQ4KUPAVCNFSM6AAAAABMJWJN7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSGY3DENRWGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: yuluo-yx <[email protected]>
…beat into 0819-yuluo/test-1
Signed-off-by: yuluo-yx <[email protected]>
|
ptal again, tks @tomsun28 |
Signed-off-by: yuluo-yx <[email protected]>
…beat into 0819-yuluo/test-1
Signed-off-by: yuluo-yx <[email protected]>
tomsun28
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.